WycliffeAssociates / DOC

Document Organization and Combination - Interleaving Multiple Scripture Resources Backend and Frontend
Other
0 stars 2 forks source link

Overlapping text in Khmer TN #163

Open abycurley opened 9 months ago

abycurley commented 9 months ago

extension://efaidnbmnnnibpcajpcglclefindmkaj/https://doc-files.bibleineverylanguage.org/km-tn-eph_km-ulb-eph_lbo_1c_chapter_ltwt.pdf

linearcombination commented 8 months ago

@abycurley It looks like the Khmer language can have incredibly long words compared to other languages. Is that correct? This makes for a tricky situation since words aren't normally broken up at end of line.

linearcombination commented 8 months ago

@abycurley Never mind, it is only PDF that is having issues with Khmer. HTML, ePub, and Docx are fine so it must be a limitation of the 3rd party library that does the HTML to PDF conversion. Would it be ok if, for now at least, I modify the system so that when Khmer is chosen then the PDF option will not be given, only ePub and Docx? A PDF can be created from the Docx from within Word.

abycurley commented 8 months ago

Yes, I think that's a good solution for now.

From: linearcombination @.> Sent: Thursday, September 21, 2023 4:03 PM To: WycliffeAssociates/DOC @.> Cc: Aby Curley @.>; Mention @.> Subject: Re: [WycliffeAssociates/DOC] Overlapping text in Khmer TN (Issue #163)

@abycurleyhttps://github.com/abycurley Never mind, it is only PDF that is having issues with Khmer. HTML, ePub, and Docx are fine so it must be a limitation of the 3rd party library that does the HTML to PDF conversion. Would it be ok if, for now at least, I modify the system so that when Khmer is chosen then the PDF option will not be given, only ePub and Docx? A PDF can be created from the Docx from within Word.

- Reply to this email directly, view it on GitHubhttps://github.com/WycliffeAssociates/DOC/issues/163#issuecomment-1730221256, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A5UK4XHCOKDDXBFDD5K25WTX3SMOHANCNFSM6AAAAAA3L4STMA. You are receiving this because you were mentioned.Message ID: @.**@.>>

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.

linearcombination commented 7 months ago

A little more info: this bug only manifests when two column formatted content is present in the Khmer document. Only TN and TQ resource get formatted as two column, so we will only disallow PDF as an output option when either of those resources for Khmer are chosen.