Open danparisd opened 5 years ago
On second review, this may not be possible. Right now I'm storing the linux JRE in the private repo the buildscript is in, because oracle won't let us download it programmatically right now. I'll have to keep looking.
On second review, this may not be possible. Right now I'm storing the linux JRE in the private repo the buildscript is in, because oracle won't let us download it programmatically right now. I'll have to keep looking.
@danparisd Would this be solved by just stashing the JRE binary somewhere private (OneDrive, S3 bucket) that the build scripts can download from? Or... just as you currently pull in dependency repos (common, resource-container), could you place this binary dependency in a WA-private GitHub repo?
@aunger Stashing it in some arbitrary cloud hosting service could make sense. I suspect I could leave it where it is in azure devops repos (VSTS) and just grab it using a creds token. I haven't had a chance to put much thought into it. Thanks for the ideas!
Travis is a better place for the build to live as testing is occurring there already. Jenkins was chosen for ease of managing secrets and install4j, but Travis handles secrets well, and I recall that others have used install4j in Travis with some minor workarounds.
This will move all buildscripts into this repo instead of the buildscripts being in a separate repo, and it will make sure that the final build succeeds with any changes made duing branch and PR checks.