Refactor to remove compiler warnings

WycliffeAssociates / otter-jvm

Desktop JVM repository for the Otter project

GNU General Public License v3.0

6 stars 1 forks source link

Refactor to remove compiler warnings #465

Closed aunger closed 5 years ago

aunger commented 5 years ago

Fix Kotlin compiler warnings:

Unnecessary null-safe ?. calls
Always-true or -false conditional predicates
Java enum interop warnings (can be nullable)
Unused parameters
Variable name shadowing
Deprecated API use
Ambiguous return@ targets
Overridden methods with differently named parameters
More?

This change is

aunger commented 5 years ago

Most of these changes are simple refactorings that should not change functionality. However, I did change functionality when the warnings seemed to indicate an actual bug. Please review carefully to be sure I didn't change something that was intentional.