search

Wykks / ngx-mapbox-gl

Angular binding of mapbox-gl-js
https://wykks.github.io/ngx-mapbox-gl
MIT License
344 stars 139 forks source link

V9.X #379

Closed Wykks closed 2 years ago

Wykks commented 2 years ago

Long time no see here :eyes:

It's been a while since I started this lib, and a lot of stuff changed since in the angular ecosystem. Sorry for not keeping this lib up to date as much as possible, I don't have any usage of this lib since years (probably 3-4 years actually). Thanks to @dmytro-gokun and others, this lib was able to stay alive enough to be usable. (Thanks again!)

As of today, I still don't have any use of this library (nor any plan to use it), but I have some spare time and a little bit re-gain of motivation. So, I started to work on a major update, in order to modernize the structure with NX, update the dependencies, and the code in general.

Note: I will remove ngx-mapbox-gl-geocoder-control and e2e tests in the process, just to lower the scope. I'll probably work on e2e later, but not on ngx-mapbox-gl-geocoder-control. PR welcome If you want to add back the code for ngx-mapbox-gl-geocoder-control after the initial v9 release.

HarelM commented 2 years ago

I'm following this library's PR in order to maintain compatibility of ngx-maplibre (a wrapper around maplibre, BTW if you want to help there as well you are more than welcome :-)).

So I basically wanted to know what's the motivation to migrate to NX? I get that the technology stack there is more commonly used (cypress, jest) but angular projects are still rigged with other defaults.

I tried to read their guide and haven't found something extremely appealing so I'm interested in your take on this...

Wykks commented 2 years ago

I'm used to work with NX for a long time now (in the js world, ~3 years is a "long time" right ? :smile: )

NX provide stuff that "@angular/cli" alone doesn't provide: in this repository, I'm interested by eslint / jest / eventually cypress (If I redo e2e tests, because protractor is dead). NX manage most of the config of theses tools for me. Basically, I want to use NX to help me maintain this repository. "nx migrate" is the main feature I'm counting on here. Just like "ng upgrade" but with a bigger scope.

Also I migrated to yarn berry, and I really like the idea of storing yarn in the repo. They got the lock file right, and now this :+1: (looking at you npm...)