search

Wykks / ngx-mapbox-gl

Angular binding of mapbox-gl-js
https://wykks.github.io/ngx-mapbox-gl
MIT License
342 stars 135 forks source link

mapbox-gl conflicting peer dependency #412

Open dereekb opened 6 months ago

dereekb commented 6 months ago

When trying to update to mapbox-gl 3.x or higher npm throws an error. Does ngx-mapbox-gl@10.0.0 support version 3 of mapbox-gl? It seems like there are no breaking changes in the API, just dropping support for some older browsers.

If so, can the peer dependencies be updated to reflect that? I can make a PR.

airbreather commented 2 weeks ago

It seems like there are no breaking changes in the API, just dropping support for some older browsers.

Maybe not, but per mapbox/mapbox-gl-js#13203, there might as well be now. I posted a workaround on that thread to show how to still use this with newer versions going forward, but these workarounds are piling up.

It feels like it's forking time now.