WyliodrinEmbeddedIoT / tockloader-rs

Other
0 stars 2 forks source link

display ports preparation #6

Closed NegrilaRares closed 1 month ago

NegrilaRares commented 2 months ago

adding the necessary changes to automate the serial port connection

george-cosma commented 2 months ago

I've marked this as draft. Mark it ready for review when you think you're happy with this feature

NegrilaRares commented 2 months ago

if u could perhaps give the current iteration a run and send me how to ports are displayed on windows that would be great

because currently i lack the means of differentiating the ports and i would like to how the information should be displayed.

NegrilaRares commented 2 months ago

it would also be great if u could give me your thoughts on adding a horizontal scroll bar

i have no idea how large the text from the type bracket of the ports is because for me it only displays Unknown.

NegrilaRares commented 2 months ago

After some further tests i have concluded that the type of the ports provided by tokio serial will be unknown in most cases, proof of it being the fact that not even on @micuami 's machine the ports are clear

I propose the idea of using tokio serial to get the port names and probe-rs for board identification

in concept this would work out fine

but im currently having some trouble with errors regarding adding probe-rs to the Cargo.toml.

NegrilaRares commented 2 months ago

the probe-rs idea does not work due to the tendency of the list command to display the last inserted debugger at the top of the list

NegrilaRares commented 2 months ago

it would seem like i was wrong probe-rs and tokio serial can possibly make this task feasable, will do the final adjustments of this idea tommorow

george-cosma commented 1 month ago

Just as a sidenote, I reccomended you run cargo fmt before every time you want to make a commit. When we reactivate the github workflows it will automatically check for it and notify you if you commited without running it. Though until then, I highly highly reccomended you run it from time to time.

george-cosma commented 1 month ago

Don't forget to fix cargo warnings and run cargo fmt