[1.14.4] Deactivated one-way glass texture does not render slab-connected side.

Wyn-Price / SecretRooms

8 stars 8 forks source link

Open fuzzyweapon opened 5 years ago

fuzzyweapon commented 5 years ago

Set down some secret glass (but do not right click a face with an empty hand, aka, don't activate camo)
Place a slab against the side of the secret glass (vanilla slab is fine and placement can be top or bottom)
Observe the glass texture for the side that the slab is placed on

The texture of the side of deactivated one-way glass doesn't render on the side to which the slab is connected.

this also occurs with vertical slabs (used ones from Quark)
activating a side while the slab is connected (or before connecting) renders the texture correctly
bug occurring with or without latest stable Optifine (1.14.4_HD_U_F4)

Wyn-Price commented 5 years ago

That's certainly an interesting bug. One way glass is a tricky one as there's so many different use cases and scenarios. I reckon it's being caused here: https://github.com/Wyn-Price/SecretRooms/blob/8ab64074918afab375a31c02e5c9b89b81d6c4ff/src/main/java/com/wynprice/secretrooms/server/blocks/OneWayGlass.java#L139-L148 , where the rendering shape doesn't get set correctly when there are no glass shapes present. Returning the empty voxel shape means that all culling should take place.

A few questions to help diagnose:

Does the same happen when the slab is a bottom slab, rather than a top slab?
Also, could you place the one way glass on some stained glass and if the slab stops it being rendered it, then place the glass on a cake and test the same.

fuzzyweapon commented 5 years ago

Finding more (different) edge cases with this further testing XD, but I'll put those in separately after further testing.

yes it happens when the slab is in the bottom position.
[stained glass] + [deactivated one way glass] + [slab] in this horizontal configuration = does trigger bug on the slab side
deactivated glass with cake (tested cake on all sides) = triggers bug for all sides

Additional unasked for testing:

I also found out that this happens on the top with secret room items if, say, you put a secret redstone door on top (which I think bodes well for this bug bc that means it's predictable).

Wyn-Price commented 3 years ago

Does this still occur