Wynntils / Artemis

Artemis is a rewrite of Wynntils in 1.20.2 using Architectury, to support Fabric and Forge.
https://wynntils.com
GNU Lesser General Public License v3.0
155 stars 80 forks source link

Guild Attack Timer Overlay does not support multiple timers on the same territory #2625

Open Essentuan opened 1 week ago

Essentuan commented 1 week ago

This is an edge case (territories can be requeued after 10 minutes) but its common enough to be a significant issue.

https://github.com/Wynntils/Artemis/assets/51426319/dda9de31-6ca9-44f1-a65f-4bfd66782ae4

Essentuan commented 1 week ago

Also another related enough issue is because each timer does not store its defense individually someone could always just say 'Llevigar Entrance defense is Very High' in guild chat and it would show the wrong defense.

kristofbolyai commented 1 week ago

Also another related enough issue is because each timer does not store its defense individually someone could always just say 'Llevigar Entrance defense is Very High' in guild chat and it would show the wrong defense.

I mean, what can you even do about this? You don't know who attacked the territory, anyone could send a message.

kristofbolyai commented 1 week ago

The original issue is fully valid though. Kind of weird, but I understand the decision behind it.

Essentuan commented 1 week ago

Also another related enough issue is because each timer does not store its defense individually someone could always just say 'Llevigar Entrance defense is Very High' in guild chat and it would show the wrong defense.

I mean, what can you even do about this? You don't know who attacked the territory, anyone could send a message.

Well its really abusable right now because the defense for a timer can be changed after the territory has been queued, once thats fixed however it also makes it significantly less abusable. (which is why I just mentioned it because its another thing that would be fixed, mostly)