Wynntils / Wynntils-Legacy

Wynntils is a Wynncraft Mod that seeks to enhance the user's gameplay with a variety of customizable options and additions.
https://wynntils.com
GNU Affero General Public License v3.0
158 stars 91 forks source link

feat: Mana timer bar #508

Closed ryanzhoudev closed 2 years ago

ryanzhoudev commented 2 years ago

Adds a bar similar to health/mana that displays time until MR cycles. Can be toggled on/off like any standard overlay, and can also switch between seconds/percentage. Calculates based on soul point ticks.

ryanzhoudev commented 2 years ago

seconds percent

magicus commented 2 years ago

I really like the idea! But... I can't make heads or tails from the animated GIFs on how this is supposed to work. What happen when they reach 100%? The mana bar adds up a few mana points. But it also adds upp mana points even before the mana timer reaches 100%. And the mana bar does not go to full mana when the mana timer goes to 100%.

Maybe I'm just lacking knowledge in how Wynncraft calculates and restores mana points. (But I might be a typical sample for a non-expert player then...) So for me, the timers as shown above would not be in any way helpful.

I'd like to see:

1) When am I going to get the next mana point back?

2) When is the mana bar going to be completely filled up again?

That'd be helpful to me. If this is what the timer is actually saying, then I think it needs a redesign to show this better, or some kind of description on how to interpret it.

ryanzhoudev commented 2 years ago

What happens when they reach 100%?

The mana timer reaching 100% is when your mana regen stat from your gear procs. Eg. if you had total 8/5 MR on your armour/weapons, you'd get 8 mana on that 100% fill.

But it also adds up mana points even before timer reaches 100%

The points continuously being added are constant and not affected by any gear stats. The timer does not take these into account because it is not significant enough to warrant any gameplay action (see below).

And the mana bar does not go to full mana when the mana timer goes to 100%

No, the mana timer is only for one cycle of your mana regen stat.

  1. When am I going to get the next mana point back?

This would be unrealistic and not really useful (imo). The point of this feature is for builds that use high -MR weapons like oblivion or ones that require switching weapons to proc MR. Since normal mana is a constant 1/second, showing this would not be useful since it would be the same between different weapons.

  1. When is the mana bar going to be completely filled up again?

I believe this would be difficult to implement and a mediocre implementation at best. There is no good way to predict how much mana the player will actually use other than, for example, an average of the player's mana usage in the last few seconds. I also highly doubt anyone is actively trying to achieve full mana during combat, because they will probably be spell cycling.

So for me, the timers as shown above would not be in any way helpful

I agree the current timer isn't useful for non-endgame/expert players, but this wasn't really implemented with that player group in mind. This feature was originally intended to make predicting -MR procs for things like Lunar Spine, Warp, and Oblivion to allow the player to swap/vanish to cancel the -MR easier. I am not sure how a non-expert/endgame player would benefit from a mana timer; Personally I don't see any value in the timer unless your weapon has a significant mana regen stat, which is rare for lower level weapons.

Please let me know if you need more clarification; I can make a video of the proposed use case if needed

magicus commented 2 years ago

@DonkeyBlaster Thank you for your explanation. I understand that this goes way above my pay grade... er, I mean level, build and skills. :-)

I'll get some inspiration from this though, and think about if I can make a noob version of this, that would be beneficial to players at my knowledge and skill level. I'm constantly confused by my mana levels and never understand how much I drain them or when they will be restored. I think I need to do some reading on the theory to be able to think of a way to communicate it better. But that really has nothing to do with this PR.