search

Wynntils / Wynntils-Legacy

Wynntils is a Wynncraft Mod that seeks to enhance the user's gameplay with a variety of customizable options and additions.
https://wynntils.com
GNU Affero General Public License v3.0
158 stars 91 forks source link

Broken Formatting for Quest Rewards #523

Closed ByThePowerOfScience closed 2 years ago

ByThePowerOfScience commented 2 years ago

Version

1.11.0_656-MC1.12.2

Brief Description

Ok, so! My dialogue patch in https://github.com/Wynntils/Wynntils/pull/512 did work, but it broke quest reward text! Somehow! Apparently the thrown Exception made everything work properly?!?!?! Well, I don't know how to fix that without VanillaFix going crazy every time someone speaks, but I figured I'd highlight the issue anyway.

Steps to Reproduce

Complete a quest and receive rewards.

Expected Behaviour

All quest rewards appear next to their bullet points, with no blank lines between quest rewards.

Actual Behaviour

2022-05-25_21 28 06

Installed Mods

I'm using the Wynncraft Remastered modpack.

ByThePowerOfScience commented 2 years ago

Honestly maybe just revert the change and add a catch statement for the ArrayIndexOutOfBoundsException on the calling method. See if that fixes it.

ryanzhoudev commented 2 years ago

Was fixed in #518.