search

Wynntils / Wynntils-Legacy

Wynntils is a Wynncraft Mod that seeks to enhance the user's gameplay with a variety of customizable options and additions.
https://wynntils.com
GNU Affero General Public License v3.0
158 stars 91 forks source link

PlayerClassProfile: Remove fields from deserializer that is not in the Wynn API anymore #528

Closed kristofbolyai closed 2 years ago

magicus commented 2 years ago

Do we think it's coming back, or should we search and remove all usages of chestsFound? (Or is it not worth it to keep Legacy clean?)

kristofbolyai commented 2 years ago

Do we think it's coming back, or should we search and remove all usages of chestsFound? (Or is it not worth it to keep Legacy clean?)

I think most of this class is not used, it's just deserialized along with the useful stuff. (iirc I checked and chestcount was not used anywhere)

magicus commented 2 years ago

Then maybe just remove it instead of commenting it out..?

kristofbolyai commented 2 years ago

Then maybe just remove it instead of commenting it out..?

Every other unused field is left there, not sure what the original intention was, but I don't think it's worth the time messing with it.

magicus commented 2 years ago

Ah, ok then.