search

Wynntils / Wynntils-Legacy

Wynntils is a Wynncraft Mod that seeks to enhance the user's gameplay with a variety of customizable options and additions.
https://wynntils.com
GNU Affero General Public License v3.0
157 stars 90 forks source link

Prevent closing chests with emeralds, amount of chest close preventions #544

Closed byBackfish closed 2 years ago

byBackfish commented 2 years ago

Implement Favoriting emeralds and option for closing chest with favorite items

You can set an amount of emeralds (per stack) there have to be for the emeralds to be marked as a favorite item and therefore preventing you from closing this chest. You can set an amount of times Wynntils should prevent you from closing the chests. If its set to X, then you have to try and close the chest X times before Wynntils actually lets you close it.

byBackfish commented 2 years ago

oops, i honestly dont know why and how i did the "Merge remote-tracking branch" thing. Sorry if it was something bad

magicus commented 2 years ago

@HeyZeer0 I think you need to approve as well, since you has marked the PR as "changes requested".

kristofbolyai commented 2 years ago

@HeyZeer0 I think you need to approve as well, since you has marked the PR as "changes requested".

I swear there was a way to dissmiss reviews, can't find it though.

magicus commented 2 years ago

Yeah, it's odd. I wonder if that is limited to someone with full admin rights like @DevScyu ?