Wynntils / Wynntils-Legacy

Wynntils is a Wynncraft Mod that seeks to enhance the user's gameplay with a variety of customizable options and additions.
https://wynntils.com
GNU Affero General Public License v3.0
158 stars 91 forks source link

feat: Party management GUI enhancements #554

Closed ryanzhoudev closed 2 years ago

ryanzhoudev commented 2 years ago

Everything should be tested pretty well since I did the testing in a dxp weekend grind party, so tons of players in various states. Also centered the entire UI properly. Was off by 5 pixels last time.

magicus commented 2 years ago

Not related to this PR, but a general wish since you're working on the party management gui: I typically want to team up with my friends. It would be nice if there were some way to have a list of common people to invite to a party. Either by parsing the friends list and showing all your friends (or, possibly, allow you to "star" a subset of your friends to have easy access to them if you have a lot of friends), or to just have a separate list of user names in the party management gui that you could add.

ryanzhoudev commented 2 years ago

Agreed, I'll also look in to a way to detect nearby players and add them to the suggestion list. Probably useful for grind parties

magicus commented 2 years ago

Yes, that'd be really nice. Not so simple to implement, though, I guess. Or maybe there is a "find entities within a BB" which you can use. (I have a vague memory about this). Also, I think we collect a list of your friends at login time. I'm not sure I remember correctly, nor if we actually use this for anything real, so if it is not being used it might have bit-rotted.

ryanzhoudev commented 2 years ago

Reviews appreciated, don't merge though, keeping the gui open slowly increases lag in-game until you close the gui so I'm trying to fix that

kristofbolyai commented 2 years ago

Seeing the image, does this fit on different resolutions?

ryanzhoudev commented 2 years ago

Seeing the image, does this fit on different resolutions?

Fits on 1020px width or larger. Imo this is fine as even 720p is 1280p wide. There's maybe another 70px maximum we could move the suggestions to the left. Legend fits great all the way down to 820px wide.