search

Wynntils / Wynntils-Legacy

Wynntils is a Wynncraft Mod that seeks to enhance the user's gameplay with a variety of customizable options and additions.
https://wynntils.com
GNU Affero General Public License v3.0
157 stars 90 forks source link

Add button to clear all waypoints #559

Closed byBackfish closed 2 years ago

byBackfish commented 2 years ago

Implements Auto delete waypoints button

image

ryanzhoudev commented 2 years ago

From what I can tell, this doesn't actually delete the waypoints from cloud and they just reappear after a relaunch. I think you will need to deal with MapConfig.Waypoints.INSTANCE.waypoints (L288; same file).

byBackfish commented 2 years ago

From what I can tell, this doesn't actually delete the waypoints from cloud and they just reappear after a relaunch. I think you will need to deal with MapConfig.Waypoints.INSTANCE.waypoints (L288; same file).

I thought onWaypointChange() would sync them? I tested it and even after restarting, they did not re-appear

byBackfish commented 2 years ago

I'll look into it tho. Thanks for letting me know

ryanzhoudev commented 2 years ago

You should fix merge conflicts before requesting review since the review will be dismissed after the resolve