Add trade market sell amount display/overlay

[byBackfish]

Pretty self explanatory

[magicus]

Is the idea to help the user set the right amount?

Can't you take it a step further, so if you e.g. right click on the amount button, the determined amount is sent as a chat message?

[byBackfish]

Is the idea to help the user set the right amount?

Can't you take it a step further, so if you e.g. right click on the amount button, the determined amount is sent as a chat message?

Good idea. I do not know why i did not think of this earlier. Ty for the suggestion

[ryanzhoudev]

https://feedback.wynntils.com/posts/21/a-sell-all-button

[magicus]

https://feedback.wynntils.com/posts/21/a-sell-all-button

@DonkeyBlaster Thanks for doing the work with confirming approval from the Wynncraft team, for this and other potential additions!

[magicus]

@byBackfish You misunderstood me. I meant that Wynntils should take care of sending the reply in chat for the user. That is, if the user right clicks on the plus, Wynntils will do the following:

• Fake a click on the "+" icon.
• Send the amount of items as a chat message sent from the user.

I realize right-clicking might be both harder to do, and less visible, so maybe a better way to trigger this would be to add an additional "+" icon below (or above, whichever looks best), give it the tooltip "Add all items of this kind", and when that is clicked, do the "dance" above.

If this needs to much knowledge of Wynntils inner workings for you to pull off, you can go with the current solution. But if possible, I think it would be much nicer to have.

[magicus]

(Also, that new "+" item could have the number you are going to add as index/"amount") so you can directly see the result of your action before doing it.

[byBackfish]

@magicus oh alright. I tried my best, hope this is fine

[byBackfish]

Actually, I thought an Emerald would look nicer than the "+", but how about making it a green checkmark?

[magicus]

Yeah, the "+" was just a suggestion. If there were a kind of "++" icon, I think that'd be the best, but whatever. I think the check mark should be reserved for executing the sale.

The drawback with the emerald is that it is already used to signal setting the price.

Maybe using a full pouch icon?

[magicus]

If you want to test the ingredient pouch idea, set id to minecraft:diamond_axe and Damage to 93. Unfortunately, I did not have a character with a full ingredient pouch (and no time to fill one up right now), so I can't give you a damage value for the full pouch icon.

[byBackfish]

Yea, I have those damage values but thanks! Wouldn't it be better to make it a full emerald pouch instead of a full ingredient pouch?

[magicus]

Maaaaaybe...? But I think my point here is that the first two slots is what you sell (item + amount), and the third is the price. And that "price" is associated with emeralds, but the other two are not. So I think the association with emeralds is a bit odd; it feels more like "set a maximum price" or so, rather than "sell all that I got".

Ideally, I think we should have some kind of stacking +:es, something along these lines: http://svn.slimdevices.com/repos/jive/7.7/trunk/squeezeplay/assets/MasterIcons/icon_add_all.png. But creating new icons is tricky and kind of out of the scope for this PR.

[byBackfish]

Once the count is above 64, the item just simply does not display. It now uses 64 if the amount would be above 64.

[magicus]

I think this looks great! :-)

[magicus]

(An alternative would be to set count to 1 if above 64, to have no number at all instead of an incorrect. But I'm not even sure that's better.)