search

Wynntils / Wynntils-Legacy

Wynntils is a Wynncraft Mod that seeks to enhance the user's gameplay with a variety of customizable options and additions.
https://wynntils.com
GNU Affero General Public License v3.0
158 stars 91 forks source link

feat: Added Arcanist Mana Bank Bar #578

Closed paotmb closed 2 years ago

paotmb commented 2 years ago

Replaces the Mana Bank boss bar with an overlay. Screenshot example

byBackfish commented 2 years ago

Also, #577 pretty much changes the boss bar update method, so if that gets merged first, then you pretty much have to do the small changes that are implemented/changed in that PR

byBackfish commented 2 years ago

Can't request changes, but I left a comment. You should probably go through your code and search for ){ and then replace all occasions of that with ) { :)

paotmb commented 2 years ago

Can't request changes, but I left a comment. You should probably go through your code and search for ){ and then replace all occasions of that with ) { :)

Ah, is this a standard practice we're using in Wynntils? I'll do that from now on.

paotmb commented 2 years ago

I have plans to add a (toggleable) sound and bar color change upon reaching 120 mana bank, indicating that Chaos Explosion will trigger on next Arcane Transfer. Next commit will fix newline + function spacing issues, and add the above.