Leveling, Player Info and Game Update XP Placeholders

[Zffu]

Hi, i have added some placeholders and changed some there is a list of things i have done

Info Component Changes

• Added the %travel% placeholder (Traveling time to get to the beacon parsed in duration)
• Added the %travel_raw% placeholder (Traveling time to get to the beacon in seconds)

Game Update Component Changes

• Added the %pc_formatted% placeholder (the %pc% placeholder but parsed)

Leveling Component Changes

• Added the %grindtime% placeholder (Griding time to get to the next level)
• Added the %grindtime_raw% placeholder (Griding time to get to the next level in seconds)
• Added the %max_formated% placeholder
• Added the %actual_formated% placeholder

Util Functions

• Added a duration parser (DurationintegerToShortString() function)
• Added a function to get the traveling time (getTravelingTime() function)

Also i would like to be a Wynntils Developper if its possible

[Zffu]

If you want me to add something please tell me

[kristofbolyai]

Also i would like to be a Wynntils Developper if its possible

You have to contribute enough so you stand out and you get an internship invitation.

[kristofbolyai]

Also, please rename your PR. You are adding info overlay and levelling overlay variables, so make sure your PR title says that.

[Incompleteusern]

The idea of the time needed to get time for grinding and time for travelling are novel, nice!

[kristofbolyai]

Other than the changes, thank you for your contribution.

I see you want to work on "Wynntils-Reloaded" (as your fork title says). Maybe you should try to contribute to https://github.com/Wynntils/Artemis. Artemis is 1.18.2 rewrite of Wynntils, and will likely replace this version of Wynntils when the porting is finished.

[Zffu]

When i mean Wynntils Reloaded i mean the 1.12.2 version also im gonna fix the extra spaces and unnedded code

[Zffu]

i think i fixed everything

[Incompleteusern]

i think i fixed everything

Still haven't resolved the valueOf comment, but everything else seems to be resolved, thanks!

[Zffu]

oh lemme fix that rq

[Zffu]

i removed the "" at the start of the return

[Zffu]

ok

[Zffu]

i can rename the new ones to %max_formated% and %actual_formated% ?

[kristofbolyai]

i can rename the new ones to %max_formated% and %actual_formated% ?

Sure. That way old variables will function the same, but there will be new, formatted ones.

[Zffu]

done

[Zffu]

fixed the elses and other things

[kristofbolyai]

@Radi0o check open conversations

[Zffu]

i resolved them

[Zffu]

i gtg rn i will add more things tomorrow i already have some cool ideas

[Zffu]

fixed

[Zffu]

Done fixing the typos

[Zffu]

and the else if

[Zffu]

@DonkeyBlaster if i have more variables to add did i need to make a new pull request?

[kristofbolyai]

@DonkeyBlaster if i have more variables to add did i need to make a new pull request?

If you don't stop updating PRs then it is never gonna get merged (change requests don't count). You should make a new PR.

[kristofbolyai]

Generally you should only open a PR if you are happy with the changes, it works, and it is semi-final version.

[Zffu]

ok

[Zffu]

oh i forgot to change this one

[Zffu]

i formatted the StringUtils function and reverted the %pc% variable