feat: Add Lootrun Variables

Wynntils / Wynntils-Legacy

Wynntils is a Wynncraft Mod that seeks to enhance the user's gameplay with a variety of customizable options and additions.

https://wynntils.com

GNU Affero General Public License v3.0

158 stars 91 forks source link

feat: Add Lootrun Variables #627

Closed Zffu closed 1 year ago

Zffu commented 1 year ago

Info Variables Changes

Added the %slc% and %session_lootrun_chests% variables (The amount of opened chests in a lootrun in the playing session)
Added the %lname% and %lootrun_name% variables (The name of the current lootrun)
Added the %sl% and %session_lootruns% variables (The amount of lootruns done in the playing session)
Added the %lc% and %lootrun_chests% variables (The amount of chests loaded in the current lootrun)
Added the %lp% and %lootrun_points% variables (The amount of points loaded in the current lootrun)
Added the %loc% and %lootrun_opened_chests% variables (The amount of opened chest during the current lootrun)

Zffu commented 1 year ago

is there anything i need to modify ?

ryanzhoudev commented 1 year ago

After unloading a lootrun, the %lname% variables does not reset. Additionally, before loading a lootrun, the %lname% variable displays as %lname. These should both be fixed; the lname variable should reset to N/A or - when nothing is loaded.

ryanzhoudev commented 1 year ago

Additionally, the %lname% variable only displays the most recently loaded lootrun, even though it is possible to load multiple runs. Maybe something like name1, name2?

Also, %SLC% tracks all chests opened when a lootrun is loaded, not just chests in the lootrun. Is this intentional?

Zffu commented 1 year ago

yes %slc% variable is the number of lootrun chests opened during the playing session

Zffu commented 1 year ago

and for the %lname% variable i can make a list of every lootrun loaded

Zffu commented 1 year ago

imma fix the %slc% chest bug

Zffu commented 1 year ago

imma fix the bugs first and then add multi lootruns comptability

Zffu commented 1 year ago

It will display that when no lootrun is loaded

Zffu commented 1 year ago

Display when there is multiple lootruns

Zffu commented 1 year ago

I am adding a hashmap for every opened chest on specific lootruns so when you disable a lootrun it removes only the chest you have opened on this lootrun

Zffu commented 1 year ago

i think im gonna remove the %loc% variable because its not very useful and it can be confusing with player location

Zffu commented 1 year ago

how to do that ?

Zffu commented 1 year ago

im gonna reopen a pull request when i finished reverting