Wynntils / Wynntils

Wynntils (Artemis) is a rewrite of Wynntils in 1.21 using Architectury, to support Fabric and Forge.
https://wynntils.com
GNU Lesser General Public License v3.0
171 stars 100 forks source link

Player ghost transparency feature makes every player transparent, including NPCs, same-server players and own player #19

Closed kristofbolyai closed 2 years ago

Incompleteusern commented 2 years ago

It works for me on fabric. Note that the code governing this is

    private static final Pattern PLAYER_GHOST_REGEX = Pattern.compile("_\\d+");

    public static boolean isPlayerGhost(Player player) {
        Team team = player.getTeam();

        if (team == null) return false;

        return PLAYER_GHOST_REGEX.matcher(team.getName()).find();
    }

Perhaps a patch changes it on forge.

kristofbolyai commented 2 years ago

On fabric, it does not seem to work at all, but it might be Wynncraft related. 2022-02-24_19 41 01 2022-02-24_19 40 56

EDIT: Actually am I blind and is it working? Let me test with lower transparency.

kristofbolyai commented 2 years ago

Nevermind, it does actually work on Fabric. Let me get some screenshots of Forge.

kristofbolyai commented 2 years ago

Forge: 2022-02-24_19 50 42 2022-02-24_19 50 47 2022-02-24_19 50 55