search

WyriHaximus / HtmlCompress

MIT License
78 stars 17 forks source link

php 8.0 compatibility #108

Closed syteknet-core closed 3 years ago

WyriHaximus commented 3 years ago

Hey @syteknet-core, thank you for this PR. Could you rebase your PR on master and do a composer update --lock -W so that the lock file is also up to date?

syteknet-core commented 3 years ago

@WyriHaximus thanks for the info. The PR is updated as requested!

WyriHaximus commented 3 years ago

@syteknet-core Thanks! FYI Also in the progress of updating some dependencies before I'm tagging a new release with this

WyriHaximus commented 3 years ago

@syteknet-core 4.1.0 is out with PHP 8 support

syteknet-core commented 3 years ago

@WyriHaximus thanks for the effort! right now a "composer update" on php 8.0.0 still fails due to a dependency

- wyrihaximus/js-compress 2.0.1 requires php ^7.2 -> your php version (8.0.0) does not satisfy that requirement.
- wyrihaximus/html-compress 4.1.0 requires wyrihaximus/js-compress ^2.0.1 -> satisfiable by wyrihaximus/js-compress[2.0.1].

this PR takes care of it!

WyriHaximus commented 3 years ago

Hold on while I go facepalm myself 😂

WyriHaximus commented 3 years ago

@syteknet-core Should work now https://github.com/WyriHaximus/php-js-compress/releases/tag/2.0.2

WyriHaximus commented 3 years ago

FYI: https://github.com/WyriHaximus/HtmlCompress/issues/114