Closed jimblue closed 3 years ago
Hah I thought I had addressed everything in the dependency chain. But it turns out jshrink
isn't yet. There is this PR https://github.com/tedious/JShrink/pull/97 that got merged, and it looks like my main issue with it has also been resolved https://github.com/tedious/JShrink/issues/96.
Just opened https://github.com/tedious/JShrink/issues/100 and hopefully, there will be a new release soon. Alternatively I have to drop it and release a new major version until it's resolved.
Thanks for your message @WyriHaximus Hopefully JShrink release with PHP 8 support will be out soon enough๐ค๐ผ ๐ค๐ผ ๐ค๐ผ
No problem @jimblue, if next weekend nothing has happened I'll go the new major version route.
Hi @WyriHaximus, just a friendly ping ๐
Well you are right, it's next weekend now @jimblue, I'll do a double major release tonight for the JS compress. One removing jshrink
and another one adding jshrink
again right after.
@jimblue try now
fixed ! thank you so much @WyriHaximus you rock ๐ฅ ๐ธ
@jimblue cheers, will keep an eye on jshrink for include it again once it's fixed
Hello,
I'm using HTMLCompress in a lib and tried to upgrade to v4.1.0 to support PHP8. When installing I'm having the following issue :