search

WyriHaximus / HtmlCompress

MIT License
77 stars 17 forks source link

Cannot assign null to property DOMElement::$id of type string #168

Closed JoomBall closed 1 month ago

JoomBall commented 3 months ago

This library always gone very well to minimize HTML, but when updating PHP 8.3 I get this error: Cannot assign null to property DOMElement::$id of type string.

Any suggestion that may be happening? thank you so much

ERROR-HTMLCOMPRESSOR

ani2life commented 3 months ago

This issue is with the voku/simple_html_dom package that this package uses. The bug has been known since last December, and a PR has been submitted, but a new version has yet to be released. https://github.com/voku/HtmlMin/issues/93

JoomBall commented 3 months ago

Thanks for the response, I see that they haven't released a new version in more than a year. Let's hope they update soon and continue with the project or we will have to find another alternative.

WyriHaximus commented 2 months ago

Just did #174 from my end to support PHP 8.3. But will have to wait for @voku's release before I will tag a new release with PHP 8.2+ support as it doesn't make sense without it. Also subscribed to https://github.com/voku/HtmlMin/issues/93 to keep myself in the loop on this issue.

Brenneisen commented 1 month ago

@WyriHaximus With the latest tags from https://github.com/voku/simple_html_dom/releases/tag/4.8.9 and https://github.com/voku/HtmlMin/releases/tag/4.5.1 the problem should be solved. The issues are still open but the fix is already merged and released: https://github.com/voku/simple_html_dom/pull/106. Is it possible to have a release here soon? Thank you!

WyriHaximus commented 1 month ago

@Brenneisen Will get a release out this weekend, not sure why Renovate isn't picking up the new releases weirdly enough

JoomBall commented 1 month ago

For me personally it has been working perfectly for more than a week, without giving any errors with PHP 8.3. after the last https://github.com/voku/simple_html_dom/releases/tag/4.8.9 update and last https://github.com/WyriHaximus/HtmlCompress/releases/tag/4.2.1.

WyriHaximus commented 1 month ago

@JoomBall Indeed a composer update should update those packages, but I'll bump them in the composer.json of this package as well to offer an 8.3 compatible version

WyriHaximus commented 1 month ago

Just tagged v4.3.0, will do some other updates and fixes the coming days but this should fix the most pressing issue.