search

WyriHaximus / HtmlCompress

MIT License
78 stars 17 forks source link

[+]: update "voku/html-min" -> "^3.1.8" -> "^4.0.4" #66

Closed voku closed 5 years ago

voku commented 5 years ago

This change is Reviewable

peter279k commented 5 years ago

The Travis CI build is failed because of failed assertions.

Could you check on this?

WyriHaximus commented 5 years ago

Reviewable status: 0 of 14 files reviewed, 5 unresolved discussions (waiting on @voku and @WyriHaximus)

tests/EdgeCasesTest.php, line 46 at r2 (raw file):

Previously, WyriHaximus (Cees-Jan Kiewiet) wrote…

Note to self: Drop this

droped

tests/HtmlMinObserverTest.php, line 45 at r2 (raw file):

Previously, WyriHaximus (Cees-Jan Kiewiet) wrote… droped

👍

tests/Compressor/HtmlCompressorTest.php, line 61 at r2 (raw file):

Previously, WyriHaximus (Cees-Jan Kiewiet) wrote… Thanks for the review. And yes you are right, it was a error in the upstream library. Fixed.

tests/EdgeCases/css-wrapped-in-comments/out.html, line 7 at r2 (raw file):

Previously, WyriHaximus (Cees-Jan Kiewiet) wrote… This was a problem of removing dom nodes, because you can't delete them on the fly, first you need to fetch all the nodes and then you can delete them. Fixed. (But I don't know exactly why this war working before?!)

Cool thanks, not sure why either tbh. Thanks for the PR, not sure when I'll tag a new release but it's probably going to be a major one so looking into other possibly breaking changes.