search

WyriHaximus / php-list-classes-in-directory

Allows you to list full qualified class names in directories and files.
MIT License
24 stars 3 forks source link

Add `listClassesInFile` and `listClassesInFiles` functions. #2

Closed azjezz closed 6 years ago

azjezz commented 6 years ago

@WyriHaximus :wave:

WyriHaximus commented 6 years ago

@azjezz 👋

azjezz commented 6 years ago

can please check why appveyor and Travis are not getting the same result ? the result seems to be different, locally i get the same result as appveyor, i don't how can i make it pass on both

WyriHaximus commented 6 years ago

@azjezz yeah sorry was looking into that, got distracted by something else and then started playing the settlers :zipper_mouth_face: .

Anyway the reason this happens is rather simple. Filesystems don't really care or even store order of nodes in a directory. Your OS (G) takes care of that, so the easiest way is to sort the classes you get from the iterator before asserting you get everything you expect.

azjezz commented 6 years ago

@WyriHaximus sorry for the late response, i get distracted last night. so what do you think about this ?

azjezz commented 6 years ago

@WyriHaximus build fail while using yield from, can you check that out ?

WyriHaximus commented 6 years ago

@WyriHaximus build fail while using yield from, can you check that out ?

Sure :+1:

WyriHaximus commented 6 years ago

@WyriHaximus build fail while using yield from, can you check that out ?

Sure 👍

Tried to figure out, just reverted it to what you initially had as that works and I have no clue how to solve this right now.

azjezz commented 6 years ago

@WyriHaximus everything is good ?

WyriHaximus commented 6 years ago

Yes everything looks good 👍 . I'll open a Hacktoberfest issue for that yield from and see if someone wants to look it.

azjezz commented 6 years ago

@WyriHaximus :clap: :raised_hands: