search

WyriHaximus / react-guzzle-http-client

Meta package for ReactPHP HttpClient adapters/handles for Guzzle 4, 5, and 6.
MIT License
10 stars 8 forks source link

option handling #5

Closed shaunbramley closed 8 years ago

shaunbramley commented 8 years ago

Fix bug #4. Fix bug #3 . Fix bug wyrihaximus/react-guzzle-psr7 - 8 Reference WyriHaximus/react-guzzle-psr7 - 3 - streams not handled properly when using Guzzle 6

Moved option handling from Request::__construct() to Request::applyOptions(). Modified default options array to be Guzzle6 compliant. Provided shim to forward convert Guzzle 4-5 option array to Guzzle 6.

Removed ProgressInterface from Request::__construct(), Request::send() method signatures. External packages only access RequestFactory::create() which does not provide an instance of ProgressInterface. This ability still exists through the use of the 'progress' option.

Explicitly state options within tests.

WyriHaximus commented 8 years ago

Looks good at first sight, will go over all the changes tonight or tomorrow. Also poked travis for all the oddly failing jobs.

WyriHaximus commented 8 years ago

Great work! Thank you for taking the time to work out and create this PR :+1: . I'll perform final tests before tagging a release with your contributions in it.