search

WyriHaximus / reactphp-child-process-messenger

MIT License
31 stars 14 forks source link

Proposal - drop indigophp/hash-compat #92

Closed FGIKCM closed 2 years ago

FGIKCM commented 2 years ago

Hello,

The indigophp/hash-compat project has been abandoned. It was made to add the hash_* functions to old PHP versions.

On each composer update we do, we now have a warning telling us we should avoid using it.

After reading the doc of hash_equals, I see that it was introduced in PHP 5.6: https://www.php.net/manual/en/function.hash-equals.php The PHP end of life branches page states that PHP 5.5 was abandoned on 2016 and is no more supported: https://www.php.net/eol.php

So I propose to not use the indigophp/hash-compat project anymore, and just use the internal PHP versions.

WyriHaximus commented 2 years ago

Hey @FGIKCM if you want to create PR's for this to the master and 4.x branches I'd be more than happy to remove this and create a new release.

WyriHaximus commented 2 years ago

Just tagged 4.0.3 with this in it, and it will also be part of the 5.0.0 release sometime in the future.