search

WyriHaximus / reactphp-child-process-pool

MIT License
40 stars 9 forks source link

Hello PHP 8 ! #57

Closed GothShoot closed 3 years ago

GothShoot commented 3 years ago

Hello,

Can you have a plan to php 8 support ?

I see you use wyrihaximus/react-child-process-messenger but it use cakephp without support of php 8. :(

Tank's for considering this issue, because one of my project use lot of async task and i plan to use php 8.

WyriHaximus commented 3 years ago

Yes, but first https://github.com/WyriHaximus/reactphp-child-process-messenger needs to support PHP 8 and I'm working on that at the moment. The problem isn't the CakePHP package, it just doesn't work at all on PHP 8 :zipper_mouth_face: .

GothShoot commented 3 years ago

What is the use of CakePHP in your other lib ?

GothShoot commented 3 years ago

I have seen your master try to use v4 of CakePHP, but is probably not working ?

WyriHaximus commented 3 years ago

What is the use of CakePHP in your other lib ?

It's using the Hash class for some conversion.

I have seen your master try to use v4 of CakePHP, but is probably not working ?

It's all working on PHP 7.4, but not yet on PHP 8. Why do you think the use of CakePHP is problematic?

GothShoot commented 3 years ago

What is the use of CakePHP in your other lib ?

It's using the Hash class for some conversion.

Okay 🤔

I have seen your master try to use v4 of CakePHP, but is probably not working ?

It's all working on PHP 7.4, but not yet on PHP 8. Why do you think the use of CakePHP is problematic?

Just a question. Do you think CakePHP be compatible rapidly? I'm don't at ease with it

WyriHaximus commented 3 years ago

What is the use of CakePHP in your other lib ?

It's using the Hash class for some conversion.

Okay

It's been a while, essentially IIRC it deflates and inflates arrays to lines and back.

I have seen your master try to use v4 of CakePHP, but is probably not working ?

It's all working on PHP 7.4, but not yet on PHP 8. Why do you think the use of CakePHP is problematic?

Just a question. Do you think CakePHP be compatible rapidly? I'm don't at ease with it

Ow they will, I'm not to worried about that. However since the master branch will become a new major version it can be replaced with something that does the same. Looking at the cakephp composer.json it's PHP targeting suggests it supports 8.

GothShoot commented 3 years ago

Thank's, I patient to see an update for PHP 8 (my pipeline already test with allow_fail).

GothShoot commented 3 years ago

Any more possility to use PHP 8 ?

WyriHaximus commented 3 years ago

As good as done, only thing to complete is https://github.com/WyriHaximus/reactphp-child-process-pool/pull/58 and then it's a matter of tagging a few releases. My only issue is that the tests are flaky, so I might have missed something along the line 🤐

GothShoot commented 3 years ago

Good 😄 Please tell me where you fix the last thing !

WyriHaximus commented 3 years ago

Just did a few releases resolving this issue. Please reopen this issue if it somehow persists for you.