search

WyriHaximus / reactphp-child-process-pool

MIT License
40 stars 9 forks source link

Void method returning boolean #73

Open gplanchat opened 2 years ago

gplanchat commented 2 years ago

Hello,

In the class WyriHaximus\React\ChildProcess\Pool\ProcessCollection\Single, the next method is returning a bool value (which isalways false). this next method should have a void return type, following the Iterator interface.

I cannot find any usage of this value elsewhere than in tests. Is this return value necessary in some point ?

WyriHaximus commented 2 years ago

IIRC it shouldn't so feel free to PR it out of there :+1: