Overhaul bin/cpuminer.sh - Githubissues

WyvernTKC / cpuminer-gr-avx2

Optimised Version of GR miner for RTM

GNU General Public License v2.0

372 stars 194 forks source link

Overhaul bin/cpuminer.sh #99

Closed slowpeek closed 5 months ago

slowpeek commented 2 years ago

Changes:

parse /proc/cpuinfo instead of lscpu output; only do it once
keep all cpu info in a single place - assoc array $cpu
streamline matches for cpu flags and features with a generic function has()
use bash regex matches instead of grep calls
streamline text highlights: hl() and warn() functions instead of literal insertion of ANSI codes
replace process in start_mining()
replace some if chains with case
$YELLOW ANSI code was red, I changed it to yellow (warn() function)
small improvements here and there

Fixes:

typo: runnig in https://github.com/WyvernTKC/cpuminer-gr-avx2/blob/d2e391d29a0e9a42de2b85c25d51824b58554411/bin/cpuminer.sh#L28
inconsistency I reported in #96 (clarity is clarity even if it doesnt affect which binary is selected in the end)
bug: missing config path in https://github.com/WyvernTKC/cpuminer-gr-avx2/blob/d2e391d29a0e9a42de2b85c25d51824b58554411/bin/cpuminer.sh#L67

Bonus:

clean shellcheck report

slowpeek commented 2 years ago

There is a bug in parse_features() with avx512 detection (OR instead of AND), fixing it.

FIXED