rradu92 commented 4 years ago

Description

Remove monero units, added zachy unit, changed donate address to testing one, added dns txt records to donate.getxcash.org

Fixes #17

Removes unnecessary monero units
Added zachy unit
Changed xcash address for donations (previous was an XMR one)
Make a donation from the wallet

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I've created a new wallet for the donations (just for testing, X-Cash team must change it to one they own), then another with 100 XCASH to make the donation from and test if donation works.

[x] I have performed a self-review of my own code
[ ] My code follows the style guidelines of this project
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

zachhildreth commented 4 years ago

Hi @rradu92 thanks for fixing this, and adding the "zachy" units everything looks great code wise!

If you can change the code to XCA1hVzVdYV4SSVG4nPvQY3SFBdHA2HbdGWPsTQsMfYehXVu5ESLsDtMg9WZozzBpR3pPcEnW2iMBVKRP1nkm3TD52Kkyq1Qrt

for the public address for donations, that would be great, or I can pull it in and then change it, but If you have time the first would be a cleaner solution

Thanks again!