X-CASH-official / xcash-core

📦 First Cryptonote coin with public & private transactions, custom DPOS consensus

https://xcash.foundation

Other

66 stars 20 forks source link

Corrected IP_address modification #19

Closed ghost closed 4 years ago

ghost commented 4 years ago

The "IP_address" modification appears to attempt to check for a decimal point "." prior to allowing the command to proceed. Instead it checks for the absence with a != before it proceeds, causing it to error if any decimal point is found.

Description

Modified the code to be '== npos', requiring at least one decimal point on an IP_address change request in the CLI.

Type of change

[X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[X] Attempted to set the IP_address from within the CLI. Code change allowed the configuration to succeed.

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
No Duplication information

zachhildreth commented 4 years ago

Thanks @CygnusMiner for finding this issue! It looks good so pulling it in