search

X-CASH-official / xcash-core

📦 First Cryptonote coin with public & private transactions, custom DPOS consensus
https://xcash.foundation
Other
66 stars 20 forks source link

Removing more mining code: miningHashRate, isMining, startMining, stopMining #32

Open franciscom0301 opened 2 years ago

franciscom0301 commented 2 years ago

Description

When linking xcash-core libs to x-cash wallet, compiler was unable to find the following mining functions:

Removing functions from wallet headers has solved the issue.

Type of change

How Has This Been Tested?

xcash-core was built and tested on the context of Android Wallet

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

zachhildreth commented 2 years ago

Thanks @franciscom0301 I got this though on the rd branch https://github.com/X-CASH-official/xcash-core/commit/ca5627f931a31f334adb9bc2d5d31d2377b013ab

but I missed the double mining hash rate

Let me add this in to the master, and then replicate on the rd branch as well, but will add to the master once I test since its blocking the lib build

Thanks for finding this!