Closed danielpes closed 6 years ago
Merging #127 into master will increase coverage by
7.15%
. The diff coverage is54.76%
.
@@ Coverage Diff @@
## master #127 +/- ##
==========================================
+ Coverage 86.13% 93.29% +7.15%
==========================================
Files 110 105 -5
Lines 1716 1401 -315
Branches 56 50 -6
==========================================
- Hits 1478 1307 -171
+ Misses 238 94 -144
Impacted Files | Coverage Δ | |
---|---|---|
...olytechnique/cmap/cnam/etl/implicits/package.scala | 0% <ø> (ø) |
:arrow_up: |
...ue/cmap/cnam/util/datetime/implicits/package.scala | 60% <0%> (-40%) |
:arrow_down: |
...fr/polytechnique/cmap/cnam/study/StudyConfig.scala | 0% <0%> (ø) |
:arrow_up: |
...ytechnique/cmap/cnam/etl/config/ConfigLoader.scala | 100% <100%> (ø) |
|
...p/cnam/study/pioglitazone/PioglitazoneConfig.scala | 100% <100%> (ø) |
:arrow_up: |
.../polytechnique/cmap/cnam/etl/sources/Sources.scala | 61.53% <18.18%> (-8.03%) |
:arrow_down: |
...ap/cnam/etl/extractors/acts/McoCEMedicalActs.scala | 73.33% <0%> (-26.67%) |
:arrow_down: |
...map/cnam/etl/transformers/follow_up/FollowUp.scala | 0% <0%> (-25%) |
:arrow_down: |
... and 16 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 35dc9f9...559f0d7. Read the comment docs.
This PR starts the refactoring towards a new config strategy (using PureConfig), including:
src/main/resources/pioglitazone
)etl.config.StudyConfig
andetl.config.ConfigLoader
PioglitazoneConfig
case class and companion loader, with testsPioglitazoneMain
and related classes (e.g.Sources
)