search

X-DataInitiative / SCALPEL-Extraction

SCALPEL extraction library to fetch concepts from flattened SNDS
BSD 3-Clause "New" or "Revised" License
17 stars 3 forks source link

CNAM-276-rosiglitazone-config-modularization #137

Closed danielpes closed 6 years ago

danielpes commented 6 years ago

Similarly to CNAM-275, this PR does a general refactoring in the RosiglitazoneConfig class. Consequently, RosiglitazoneMain is also changed.

As side-effects, I had to fix a typo and add a missing write.parquet in PioglitazoneMain. Also, I had to improve the CoproductHint in ConfigLoader to be able to read "heart_failure" from the rosiglitazone config file.

codecov[bot] commented 6 years ago

Codecov Report

Merging #137 into master will decrease coverage by 0.11%. The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
- Coverage   94.44%   94.32%   -0.12%     
==========================================
  Files         119      121       +2     
  Lines        1439     1444       +5     
  Branches       25       30       +5     
==========================================
+ Hits         1359     1362       +3     
- Misses         80       82       +2
Impacted Files Coverage Δ
...am/study/rosiglitazone/outcomes/HeartFailure.scala 0% <0%> (ø)
.../polytechnique/cmap/cnam/etl/sources/Sources.scala 61.53% <0%> (ø) :arrow_up:
.../cnam/study/rosiglitazone/outcomes/Infarctus.scala 100% <100%> (ø)
...cnam/study/rosiglitazone/RosiglitazoneConfig.scala 100% <100%> (ø) :arrow_up:
...one/outcomes/RosiglitazoneOutcomeTransformer.scala 100% <100%> (ø)
.../study/rosiglitazone/RosiglitazoneStudyCodes.scala 100% <100%> (ø) :arrow_up:
...ytechnique/cmap/cnam/etl/config/ConfigLoader.scala 91.66% <100%> (+0.75%) :arrow_up:
...udy/rosiglitazone/outcomes/OutcomeDefinition.scala 60% <60%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3047aaf...6e42466. Read the comment docs.