X-DataInitiative / SCALPEL-Extraction

SCALPEL extraction library to fetch concepts from flattened SNDS
BSD 3-Clause "New" or "Revised" License
17 stars 3 forks source link

CNAM-328 Function to obtain flowcharts instantly #148

Closed Vishy26 closed 6 years ago

Vishy26 commented 6 years ago

The created function in script asks for three string parameters as input: Metadata_json filepath, Flowchart_json filepath, and output file directory. The function created the flowcharts on the metadata according to the flowchart_json, and outputs the Pdf to the output filepath.

codecov[bot] commented 6 years ago

Codecov Report

Merging #148 into master will decrease coverage by 0.33%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
- Coverage    93.9%   93.57%   -0.34%     
==========================================
  Files         132      125       -7     
  Lines        1543     1494      -49     
  Branches       50       49       -1     
==========================================
- Hits         1449     1398      -51     
- Misses         94       96       +2
Impacted Files Coverage Δ
...olytechnique/cmap/cnam/etl/implicits/package.scala 0% <0%> (-100%) :arrow_down:
.../polytechnique/cmap/cnam/etl/sources/Sources.scala 61.53% <0%> (-38.47%) :arrow_down:
...ytechnique/cmap/cnam/etl/config/ConfigLoader.scala 91.66% <0%> (-8.34%) :arrow_down:
...ue/cmap/cnam/util/datetime/implicits/package.scala 80% <0%> (-5.72%) :arrow_down:
...cnam/study/rosiglitazone/RosiglitazoneConfig.scala 100% <0%> (ø) :arrow_up:
...l/extractors/molecules/DcirMoleculePurchases.scala 100% <0%> (ø) :arrow_up:
.../cmap/cnam/etl/loaders/mlpp/DiscreteExposure.scala 100% <0%> (ø) :arrow_up:
...map/cnam/etl/extractors/drugs/DrugsExtractor.scala 100% <0%> (ø) :arrow_up:
...p/cnam/study/pioglitazone/PioglitazoneConfig.scala 100% <0%> (ø) :arrow_up:
...ique/cmap/cnam/etl/loaders/mlpp/MLPPOutcomes.scala 100% <0%> (ø) :arrow_up:
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f797141...3ee4454. Read the comment docs.

dsun0720 commented 6 years ago

@Vishy26, we reverted the master to the old version. Before you merge your code in the master, you should operate a command like git rebase --onto : https://stackoverflow.com/questions/29914052/i-cant-understand-the-behaviour-of-git-rebase-onto, to be sure of only your own commit in the head of the history.