X-DataInitiative / SCALPEL-Extraction

SCALPEL extraction library to fetch concepts from flattened SNDS
BSD 3-Clause "New" or "Revised" License
17 stars 3 forks source link

CNAM-330: on/off for outcome and exposure in the fall #168

Closed dsun0720 closed 6 years ago

dsun0720 commented 6 years ago

The goal is to make it possible to decide at runtime what to compute.

The test is well done in cmap

codecov[bot] commented 6 years ago

Codecov Report

Merging #168 into master will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage   93.35%   93.38%   +0.02%     
==========================================
  Files         133      133              
  Lines        1566     1573       +7     
  Branches       52       30      -22     
==========================================
+ Hits         1462     1469       +7     
  Misses        104      104
Impacted Files Coverage Δ
...map/cnam/etl/extractors/acts/DcirMedicalActs.scala 100% <100%> (ø) :arrow_up:
...nique/cmap/cnam/study/fall/config/FallConfig.scala 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2c693d2...8e2af34. Read the comment docs.

dsun0720 commented 6 years ago

The tests ran in CMAP(env: 96 cores, 110G in executor memory, 40G in drive memory) Fall : 40min

branch["Acts", "Diagnoses", "Outcomes"] : 31min branch["Acts"] : 26min branch["Diagnoses"] : 5min

branch["Patients", "StartGapPatients", "DrugPurchases", "Exposures"] : 9min branch["DrugPurchases"] : 2min branch["Patients"] : 5min branch["Patients", "DrugPurchases", "StartGapPatients"] : 8min