Closed ysebiat closed 5 years ago
Merging #185 into master will decrease coverage by
0.21%
. The diff coverage is91.41%
.
@@ Coverage Diff @@
## master #185 +/- ##
=========================================
- Coverage 93.62% 93.4% -0.22%
=========================================
Files 148 152 +4
Lines 1678 1669 -9
Branches 26 26
=========================================
- Hits 1571 1559 -12
- Misses 107 110 +3
Impacted Files | Coverage Δ | |
---|---|---|
...gs/classification/families/Antihypertenseurs.scala | 100% <ø> (ø) |
|
...cnam/study/rosiglitazone/RosiglitazoneConfig.scala | 100% <ø> (ø) |
:arrow_up: |
...rs/drugs/classification/families/Hypnotiques.scala | 100% <ø> (ø) |
|
...nam/etl/extractors/diagnoses/DiagnosesConfig.scala | 100% <ø> (ø) |
:arrow_up: |
...ue/cmap/cnam/etl/extractors/drugs/DrugConfig.scala | 100% <ø> (ø) |
:arrow_up: |
...cmap/cnam/study/fall/config/FallConfigLoader.scala | 100% <ø> (ø) |
:arrow_up: |
...p/cnam/study/fall/config/FallDrugClassConfig.scala | 100% <ø> (ø) |
:arrow_up: |
...ytechnique/cmap/cnam/etl/config/ConfigLoader.scala | 100% <ø> (ø) |
:arrow_up: |
...nam/study/rosiglitazone/extractors/Diagnoses.scala | 0% <0%> (ø) |
|
...cnam/study/pioglitazone/extractors/Diagnoses.scala | 0% <0%> (ø) |
|
... and 61 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update dbe424e...d1b24af. Read the comment docs.
This ready now. This is the check list that I will have to go through
I see your point. I will probably add it then. The DCIREvent Extractor.
@dsun0720 I have added the DCIREventsExtractor and made sure that it is running for Fall study. Can you have another look please?
code approved, rebase the code before merge.
Good job
This PR has the main objective of rewriting the Extractor logic. It allows to make a trait that defines what an Extractor is according to the Pipeline Paper. It also allows a default behaviour; when every Event that can be extracted is extracted: a Bulk Main.
So this PR is: