X-DataInitiative / SCALPEL-Extraction

SCALPEL extraction library to fetch concepts from flattened SNDS
BSD 3-Clause "New" or "Revised" License
17 stars 3 forks source link

Cnam-376 empty code list #185

Closed ysebiat closed 5 years ago

ysebiat commented 5 years ago

This PR has the main objective of rewriting the Extractor logic. It allows to make a trait that defines what an Extractor is according to the Pipeline Paper. It also allows a default behaviour; when every Event that can be extracted is extracted: a Bulk Main.

So this PR is:

  1. Create a new trait Extractor.
  2. Add a new behaviour where all Events are extracted from the input sources.
  3. Add a BulkMain to extract all the Events.
  4. Add a new level of Drug Purchases namely, CIP13 level.
codecov[bot] commented 5 years ago

Codecov Report

Merging #185 into master will decrease coverage by 0.21%. The diff coverage is 91.41%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #185      +/-   ##
=========================================
- Coverage   93.62%   93.4%   -0.22%     
=========================================
  Files         148     152       +4     
  Lines        1678    1669       -9     
  Branches       26      26              
=========================================
- Hits         1571    1559      -12     
- Misses        107     110       +3
Impacted Files Coverage Δ
...gs/classification/families/Antihypertenseurs.scala 100% <ø> (ø)
...cnam/study/rosiglitazone/RosiglitazoneConfig.scala 100% <ø> (ø) :arrow_up:
...rs/drugs/classification/families/Hypnotiques.scala 100% <ø> (ø)
...nam/etl/extractors/diagnoses/DiagnosesConfig.scala 100% <ø> (ø) :arrow_up:
...ue/cmap/cnam/etl/extractors/drugs/DrugConfig.scala 100% <ø> (ø) :arrow_up:
...cmap/cnam/study/fall/config/FallConfigLoader.scala 100% <ø> (ø) :arrow_up:
...p/cnam/study/fall/config/FallDrugClassConfig.scala 100% <ø> (ø) :arrow_up:
...ytechnique/cmap/cnam/etl/config/ConfigLoader.scala 100% <ø> (ø) :arrow_up:
...nam/study/rosiglitazone/extractors/Diagnoses.scala 0% <0%> (ø)
...cnam/study/pioglitazone/extractors/Diagnoses.scala 0% <0%> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dbe424e...d1b24af. Read the comment docs.

ysebiat commented 5 years ago

This ready now. This is the check list that I will have to go through

ysebiat commented 5 years ago

I see your point. I will probably add it then. The DCIREvent Extractor.

ysebiat commented 5 years ago

@dsun0720 I have added the DCIREventsExtractor and made sure that it is running for Fall study. Can you have another look please?

dsun0720 commented 5 years ago

code approved, rebase the code before merge.

Good job