X-DataInitiative / SCALPEL-Extraction

SCALPEL extraction library to fetch concepts from flattened SNDS
BSD 3-Clause "New" or "Revised" License
17 stars 3 forks source link

CNAM-432: Refactoring in drugs and followup test classes, not used m… #230

Closed Anfor closed 4 years ago

Anfor commented 4 years ago

…ethods removed and finish implementation in DrugExtractor

Anfor commented 4 years ago

I create this branch to avoid problem merging

codecov[bot] commented 4 years ago

Codecov Report

Merging #230 into develop will increase coverage by 0.94%. The diff coverage is 92.3%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #230      +/-   ##
===========================================
+ Coverage     92.9%   93.84%   +0.94%     
===========================================
  Files          183      183              
  Lines         2282     2242      -40     
  Branches        62       62              
===========================================
- Hits          2120     2104      -16     
+ Misses         162      138      -24
Impacted Files Coverage Δ
...que/cmap/cnam/etl/extractors/dcir/DcirSource.scala 95.45% <ø> (ø) :arrow_up:
.../polytechnique/cmap/cnam/etl/events/FollowUp.scala 100% <ø> (ø) :arrow_up:
...cmap/cnam/etl/transformers/follow_up/Columns.scala 53.33% <ø> (-2.92%) :arrow_down:
...ers/observation/ObservationPeriodTransformer.scala 100% <ø> (ø) :arrow_up:
...nique/cmap/cnam/etl/events/ObservationPeriod.scala 100% <ø> (+66.66%) :arrow_up:
...ap/cnam/etl/transformers/observation/Columns.scala 53.33% <ø> (ø) :arrow_up:
...l/transformers/follow_up/FollowUpTransformer.scala 100% <100%> (ø) :arrow_up:
...cmap/cnam/etl/extractors/drugs/DrugExtractor.scala 100% <100%> (ø) :arrow_up:
.../cmap/cnam/etl/extractors/dcir/DcirExtractor.scala 100% <100%> (ø) :arrow_up:
...a/fr/polytechnique/cmap/cnam/etl/events/Drug.scala 100% <100%> (ø) :arrow_up:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6e2fa10...f8b4e4e. Read the comment docs.