search

X-DataInitiative / SCALPEL-Extraction

SCALPEL extraction library to fetch concepts from flattened SNDS
BSD 3-Clause "New" or "Revised" License
17 stars 3 forks source link

CNAM-286: Refactoring Patients #257

Closed kevtokev closed 4 years ago

kevtokev commented 4 years ago

Refactoring Patients : New abstraction of Patients Extractors Uniform all extractors of patients from different sources Separation of extractors and filters Separation of algorithms to calculate gender, birthDate and deathDate

codecov[bot] commented 4 years ago

Codecov Report

Merging #257 into develop will increase coverage by 0.24%. The diff coverage is 98.30%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #257      +/-   ##
===========================================
+ Coverage    93.50%   93.75%   +0.24%     
===========================================
  Files          218      220       +2     
  Lines         2586     2721     +135     
  Branches        72       85      +13     
===========================================
+ Hits          2418     2551     +133     
- Misses         168      170       +2
Impacted Files Coverage Δ
.../cnam/etl/extractors/patients/PatientsConfig.scala 100.00% <ø> (ø)
.../cnam/study/bulk/extractors/PatientExtractor.scala 0.00% <0.00%> (ø)
...nique/cmap/cnam/study/fall/FallMainTransform.scala 99.11% <ø> (ø)
...nam/etl/transformers/patients/PatientFilters.scala 93.75% <93.75%> (ø)
...chnique/cmap/cnam/study/fall/FallMainExtract.scala 98.78% <93.75%> (-0.56%) :arrow_down:
...ap/cnam/etl/extractors/patients/DcirPatients.scala 97.50% <97.36%> (-2.50%) :arrow_down:
.../etl/extractors/patients/AllPatientExtractor.scala 100.00% <100.00%> (ø)
...map/cnam/etl/extractors/patients/HadPatients.scala 100.00% <100.00%> (ø)
...p/cnam/etl/extractors/patients/IrBenPatients.scala 100.00% <100.00%> (ø)
...map/cnam/etl/extractors/patients/McoPatients.scala 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 714aa3e...0895435. Read the comment docs.

dsun0720 commented 4 years ago

I looked up your new commit, i think it's ok now. But did you make a full test in the cnam to be sure that you code will produce the same result as before ?

dsun0720 commented 4 years ago

add comments and squash before merge