X-DataInitiative / tick

Module for statistical learning, with a particular emphasis on time-dependent modelling
https://x-datainitiative.github.io/tick/
BSD 3-Clause "New" or "Revised" License
484 stars 105 forks source link

Issues in code #423

Closed RuihuaRUAN closed 4 years ago

RuihuaRUAN commented 4 years ago

Hi,

There could be a little error on the line 166 in

tick/tick/hawkes/simulation/base/simu_point_process.py

     if self.end_time is None and self.max_jumps is None:
        raise (ValueError('Either end_time or max_jumps must be set'))
                                          .............
     elif self.end_time is None and self.max_jumps is None:
        self._pp.simulate(self.end_time, self.max_jumps)

I think the last condition should be elif self.end_time is not None and self.max_jumps is not None:.

Regards, Ruihua

PhilipDeegan commented 4 years ago

PR welcome!

PhilipDeegan commented 4 years ago

https://github.com/X-DataInitiative/tick/blob/master/tick/hawkes/simulation/base/simu_point_process.py#L166 fixed