search

X-DataInitiative / tick

Module for statistical learning, with a particular emphasis on time-dependent modelling
https://x-datainitiative.github.io/tick/
BSD 3-Clause "New" or "Revised" License
484 stars 105 forks source link

tick.hawkes.SimuHawkesExpKernels seed max values #428

Open jdeschena opened 4 years ago

jdeschena commented 4 years ago

Hi,

While generating hawkes processes with exponential kernels, I ran into an issue with the (optional) seed value. By providing a far too big value (2 42 for example), we are told that the maximal allowed value for seed is 2 32 - 1. However, when passing a seed between 2 31 (included) and 2 32 (included), we get an internal error telling us that the given parameters doesn't have type int.

Thank you

Mbompr commented 4 years ago

Max integer is 2**31 − 1. Indeed, maybe we should change the error message... Does 2**30 works ?

jdeschena commented 4 years ago

Hello, thanks for you answer. Indeed 2**30 works fine.