search

X-DataInitiative / tick

Module for statistical learning, with a particular emphasis on time-dependent modelling
https://x-datainitiative.github.io/tick/
BSD 3-Clause "New" or "Revised" License
484 stars 105 forks source link

Typo and wrong charts in plot_time_function.py #452

Closed MarcosCarreira closed 4 years ago

MarcosCarreira commented 4 years ago

The last loop:

for tf, ax in zip(time_functions, ax_list): plot_timefunction(tf_1, ax=ax) ax.set_ylim([-0.5, 6.0]) plt.show()

Should be:

for tf, ax in zip(time_functions, ax_list): plot_timefunction(tf, ax=ax) ax.set_ylim([-0.5, 6.0]) plt.show()

And now the charts will be different (now they're all the same).

PhilipDeegan commented 4 years ago

PRs are welcome @MarcosCarreira

PhilipDeegan commented 4 years ago

I believe this has been resolved

MarcosCarreira commented 4 years ago

Yes, the PR was accepted. https://github.com/X-DataInitiative/tick/blob/master/doc/modules/code_samples/plot_time_function.py is Ok now but https://x-datainitiative.github.io/tick/auto_examples/plot_time_function.html still shows the old version.

PhilipDeegan commented 4 years ago

ok we have to regenerate the documentation, thanks @MarcosCarreira