lgtm-com[bot]
commented
2 years ago This pull request fixes 11 alerts when merging 35dcd0d5e9ab7e3893271415ed89cf290d96b768 into bbc561804eb1fdcb4c71b9e3e2d83a66e7b13a48 - view on LGTM.com
fixed alerts:
- 2 for Unused import
- 2 for Variable defined multiple times
- 2 for Unused exception object
- 1 for Unnecessary pass
- 1 for Module is imported more than once
- 1 for Unused local variable
- 1 for Unreachable code
- 1 for Comparison result is always the same
Lots of things in distutils/setup are being deprecated, so I think by python3.11 it won't work at all. Given that I have updated the action builds to use my own build tool mkn
Currently (and previously) on github actions tests we did not run C++ tests as gtest was not installed so it was skipped. This PR readds C++ tests.
The googletest latest code is now using C++14 (or higher) and I have configured mkn to remain tied to the last C++11 version of googletest. I don't see why we couldn't upgrade also to at least C++17.
However: OSX still has a bunch of errors during pytests for random, which I didn't want to skip for all OSes, more thought is needed here. OSX is still not built in PRs, even though it does build just fails during some pytests. On Windows, action builds fail with some nefarious DLL init errors, I do not have DLL issues on my local windows install but I will upgrade my compiler to verify as having more versions on windows would be good. Python3.11 has problem with assertRaisesRegex, so to assess