search

X-Guard / react-native-flic2

Use Flic 2 within your React Native application with ease.
Other
8 stars 9 forks source link

Fix notification #18

Closed LucasMonteiro1 closed 3 years ago

LucasMonteiro1 commented 3 years ago

Added option to set custom title and text to notification. (Fix #11)

According to https://github.com/50ButtonsEach/flic2lib-android/issues/15 show Android Service only when buttons are connected. (Fix #15)

jdegger commented 3 years ago

Hi @LucasMonteiro1 thank you for your contribution! Highly appreciated.

We will review and test the PR in a few days :) We will get back to you as soon as possible.

Thanks again

jdegger commented 3 years ago

Hi @LucasMonteiro1 we noticed one problem with your implementation. @wesdewitte posted a comment addressing it. Could you look into this?

Many thanks!

jdegger commented 3 years ago

Hi @LucasMonteiro1 your PR has been closed as we used your work in https://github.com/X-Guard/react-native-flic2/pull/19 and will merge that.

Thank you for your contribution!