search

X-Guard / react-native-flic2

Use Flic 2 within your React Native application with ease.
Other
8 stars 9 forks source link

Ios android both work #8

Closed michaelbyrd123 closed 4 years ago

jdegger commented 4 years ago

Hi @michaelbyrd123, I do not completely understand the goal of your PR and what you were trying to achieve. Can we help you?

michaelbyrd123 commented 4 years ago

@jdegger I was getting errors regarding unimplemented methods on the android side when i tried to run as is regarding the onAllQueuedButtonEventsProcessed. I also had some issues using versions greater than 0.3.0 on ios, was getting module include errors with the flic2lib

michaelbyrd123 commented 4 years ago

didnt meant the create a pull request, that was a fat finger.

michaelbyrd123 commented 4 years ago

The main thing was the changes to this file to get rid of the errors I was seeing. https://github.com/michaelbyrd123/react-native-flic2/blob/ios-android-both-work/android/src/main/java/nl/xguard/flic2/callback/flic2ButtonCallback.java

jdegger commented 4 years ago

The library has been updated since your PR. The errors might be gone in a rather large overhaul of the lib.