X-Guardian / AdfsDsc

DSC resources for deployment and configuration of Active Directory Federation Services
MIT License
9 stars 5 forks source link

AdfsWebApiApplication: Add Support for Access Control Policy Parameters #21

Closed X-Guardian closed 4 years ago

X-Guardian commented 4 years ago

Pull Request (PR) description

This PR adds support for Access Control Policy Parameters to the AdfsWebApiApplication resource.

Currently only GroupParameter is supported, which is enough to support all the built-in access control policies.

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 4 years ago

Codecov Report

Merging #21 into dev will decrease coverage by 0.03%. The diff coverage is 98.14%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev      #21      +/-   ##
=========================================
- Coverage   98.1%   98.06%   -0.04%     
=========================================
  Files         16       16              
  Lines       1685     1760      +75     
=========================================
+ Hits        1653     1726      +73     
- Misses        32       34       +2
Impacted Files Coverage Δ
...sRelyingPartyTrust/MSFT_AdfsRelyingPartyTrust.psm1 100% <100%> (ø) :arrow_up:
...sWebApiApplication/MSFT_AdfsWebApiApplication.psm1 100% <100%> (ø) :arrow_up:
Modules/AdfsDsc.Common/AdfsDsc.Common.psm1 91.34% <96.77%> (+0.28%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 276218c...7c68367. Read the comment docs.