AdfsServerApplication: Add basic support for AdfsServerApplication

watschi commented 8 months ago

Pull Request (PR) description

This PR adds basic support for AdfsServerApplication. For authentication of the Server Application only ADUserPrincipalName can be configured for now, client secrets or certificates are not configurable.

This Pull Request (PR) fixes the following issues

None

Task list

[x] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable).
[x] Resource documentation added/updated in README.md.
[x] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
[x] Comment-based help added/updated.
[x] Localization strings added/updated in all localization files as appropriate.
[x] Examples appropriately added/updated.
[x] Unit tests added/updated. See DSC Community Testing Guidelines.
[x] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
[x] New/changed code adheres to DSC Community Style Guidelines.

This change is

watschi commented 8 months ago

Hi @X-Guardian,

not sure why the pipeline fails, according to a quick google search the download error can be an intermittent node and/or permission issue. The run on my forked repo went thorugh succesfully: https://dev.azure.com/fabianwendlandt0807/AdfsDsc/_build/results?buildId=10&view=results

Maybe you can retrigger your pipeline?

Thanks!

X-Guardian commented 8 months ago

Still failed after retrying. The delights of Azure DevOps! I'll try and take a look at the pipeline issue later today.

Thanks for the PR @watschi. Nice to know people are using the module.

codecov[bot] commented 8 months ago

Codecov Report

Merging #74 (7c7f093) into main (40a666b) will increase coverage by 0%. Report is 4 commits behind head on main. The diff coverage is 100%.

@@         Coverage Diff          @@
##           main    #74    +/-   ##
====================================
  Coverage    98%    98%            
====================================
  Files        16     17     +1     
  Lines      2146   2272   +126     
====================================
+ Hits       2110   2236   +126     
  Misses       36     36

X-Guardian commented 8 months ago

Looks good @watschi. Have you been able to run the integration tests successfully yourself?

watschi commented 8 months ago

Hi @X-Guardian, thanks for fixing the pipeline!

I thought integration tests are running in the default test runs, apperantly not. I did push a configuration to an ADFS farm succesfully, but will run integration tests tomorrow and report the results in here after. I also noticed an oversight in the localization strings (copied from AdfsNativeClient) which I'll fix.

X-Guardian commented 8 months ago

No, the integration tests need an Active Directory, which is tricky to setup in the CI, so have always been run offline manually.

watschi commented 8 months ago

Fixed the localization strings as mentioned and was able to run the integration tests succesfully (transcript attached: adfsdsc_integration.log).

Please let me know if there's anything else I can help with!

grafik

X-Guardian commented 8 months ago

Hi @watschi, this has been released in v1.4.0

watschi commented 8 months ago

Thanks for fixing the pipeline and merging so quickly! :)

X-Guardian / AdfsDsc