search

X-Guardian / xAdfs

DSC Resource to install and manage ADFS
MIT License
4 stars 2 forks source link

Include in the PowerShell DSC Resource Kit #4

Open jonathaneckman opened 6 years ago

jonathaneckman commented 6 years ago

Add this module to the DSC Resource Kit.

Prerequisites referenced here.

X-Guardian commented 5 years ago

Hi @jcwalker, it would be great if this module was made part of the DSC Resource Kit and published to the PowerShell Gallery. I'm happy to submit some PR's to get this up to the HQRM guidelines, if you are available to review them?

jcwalker commented 5 years ago

I don't think any new resources are allowed in the DSC resource kit. However, if you are willing to make the changes to put it inline with the HQRM guidelines we can definitely publish it in the gallery.

X-Guardian commented 5 years ago

Yes they are. See New Resource Module Submissions. I'll start raising PR's to bring the module in line with the guidelines.

jcwalker commented 5 years ago

That page references adding a submodule to an existing module. I say they aren't accepting any new modules because a colleague tried to get AccessControlDsc included in the resource kit and was told no new resources in the resource kit.

X-Guardian commented 5 years ago

Hi @johlju, can modules still be added to the DSC resource kit?

johlju commented 5 years ago

Not added, but linked from the DSC Resource Kit. We could always discuss adding it to DSC Community if that would be of interest.

X-Guardian commented 5 years ago

Ok, the same as xWebAdministration etc, yes?

johlju commented 5 years ago

xWebAdministration is in the PowerShell organization currently, but hopefully it will be moved together with the rest of the DSC repos to DSC community organization. https://GitHub.com/dsccommunity https://dsccommunity.org

johlju commented 5 years ago

If linked to the DSC Recource Kit in the PowerShell organization the repo would still be at this current location.

johlju commented 5 years ago

For the later, read more here https://github.com/PowerShell/DscResources/blob/master/NewResourceModuleSubmissions.md

X-Guardian commented 5 years ago

Cheers @johlju.

@jcwalker, I've got an updated branch with a preliminary working AppVeyor build. Can you create a dev branch on this Repo and make it the default, then add the Repo to Appveyor. I'll then raise a PR from my branch to dev.

jcwalker commented 5 years ago

@X-Guardian would you mind me transferring ownership of the repo to you?

X-Guardian commented 5 years ago

Yes that's fine

jcwalker commented 5 years ago

@X-Guardian when I attempt to transfer the repository to you I receive the message "X-Guardian\xAdfs" already exists. I'm not sure the best course of action is. Maybe rename your current fork of xAdfs is that's possible?

X-Guardian commented 5 years ago

I've deleted my fork of this repo, so you should be able to transfer it now.