X-Hax / SA-Mod-Manager

A new mod manager for the Sonic Adventure games.
MIT License
70 stars 17 forks source link

[Suggestion] Filtering settings for supersampled anti-aliasing/downsampling #211

Open BrochachoTheBro opened 1 month ago

BrochachoTheBro commented 1 month ago

I think whenever you play either game with a higher-than-native resolution, there isn't a filter applied to make supersampling apparent. I tried using the Custom Window setting since that's the only Screen Mode that allows for independent Render Resolution and Window Size variables, but with the Render Res set to 1440p and the Window Size set to 720p (half), you can clearly still see jagged edges. Snipping tool screenshot of the game window @ 720p: Screenshot 2024-09-17 132737 Screenshot of the game taken with Steam: 213610_20240917132631_1 Said Steam screenshot is actually 1440p and not 720p image So do you think it'd be possible to add a setting in the Display Options for window filtering options? Such as Bilinear, Gaussian, Lanczos, Bicubic, etc., while still keeping the option for the current Nearest Neighbor option used?

PiKeyAr commented 1 month ago

Can confirm this is affecting SADX as well. It appears that the game doesn't render at higher resolutions when window/screen size < render resolution, and just uses the window or screen resolution for rendering. I doubt it's an issue with the manager though, seems like an issue with window stuff in respective mod loaders.

So do you think it'd be possible to add a setting in the Display Options for window filtering options? Such as Bilinear, Gaussian, Lanczos, Bicubic, etc., while still keeping the option for the current Nearest Neighbor option used?

There's no filtering being applied currently, Nearest Neighbor or otherwise.

PiKeyAr commented 1 month ago

I did a comparison between different resolutions with the same window size. I'm not sure why the downsampling effects are practically invisible on 3D stuff but there does seem to be a difference judging by the appearance of textures.

Rendering 720p, window 720p image

Rendering 4k, window 720p image

BrochachoTheBro commented 1 month ago

Hmm yeah, that texture difference adds to my theory of the downsampling being unfiltered, its as if you're increasing the anisotropic filtering samples (as a comparison). But yeah as I suggested, it would be worth considering adding filtering options for true AA when supersampling if its not too much to ask for, since it might just be pressing the view down with nearest filtering.

ItsEasyActually commented 4 weeks ago

Some others also looked into this and it does appear there's some weird downsampling stuff going on, but I don't believe this is technically a bug. It's more of an enhancement for the game, but it's more work than just the Manager side of things.

Discussion would need to continue in the SADX Mod Loader and the SA2 Mod Loader repositories regarding implementation for the game side of things. Alternatively someone could just make a mod to handle this, maybe anyway.