I am submitting this as a PR to request review as a structure has had a field changed from signed to unsigned, and none of these code changes have been tested.
Changes include:
Fix use of " for including global headers to correctly use <> instead (i.e. (#include "d3dx9.h" -> #include <d3dx9.h>)
Fix a bunch of signed/unsigned mismatches
Fix nested for loop shadowing variables (for (int i = 0; ...) nested inside loop already using int i)
Fix a bunch of messy code copy/pasted from IDA verbatim (please clean up code that you copy from IDA!), including:
float/double mismatches
signed/unsigned mismatches
unused variables due to modified code
use of 0 instead of nullptr
missing explicit type conversion (e.g. float to short)
Please don't introduce avoidable warnings. These are all indicative of potential problems with the code.
Unavoidable warnings include one produced by a bug in DbgHelp.h that Microsoft claimed to have (and have not) fixed in our compiler version, as well as the deprecation warning for Windows XP target support. If not for these, I would suggest enabling warnings as errors.
I am submitting this as a PR to request review as a structure has had a field changed from signed to unsigned, and none of these code changes have been tested.
Changes include:
"for including global headers to correctly use<>instead (i.e. (#include "d3dx9.h"->#include <d3dx9.h>)for (int i = 0; ...)nested inside loop already usingint i)0instead ofnullptrfloattoshort)Please don't introduce avoidable warnings. These are all indicative of potential problems with the code.
Unavoidable warnings include one produced by a bug in DbgHelp.h that Microsoft claimed to have (and have not) fixed in our compiler version, as well as the deprecation warning for Windows XP target support. If not for these, I would suggest enabling warnings as errors.